Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to test that this doesn't have negative performance implications before merging.
This was originally broken by 98711ca
Update with Testing performance:
If I have 10 component running simultaneously, all logging to the service every 0.01 seconds, there is no performance difference. This is the most extreme case that you might find in practice.
Only in the most extreme cases do I see a difference, so 10 component running simultaneously, all logging to the service as fast as they can
then the total run time goes from ~5 seconds on the current
master
to ~15 seconds on this branch. But the output log file is now correct,master
log file was 1642 lines long while this branch is 100044 lines. Given that this is unlikely how it will be used I think it is safe to go ahead with this fix.Update with testing performance on Cori (working on $HOME):
Previous test was on my local computer
Do this same test
I see no difference in total execution time (from
IPS_START
toIPS_END
) on Cori, if was 103.6 seconds without this fix and 103.5 seconds with it and it now has the correct logs in the file . So this is good to go.Also
ipsframework.ipsLogging.IPSLogSocketHandler
was able to be replaced withlogging.handlers.SocketHandler
(Ref #34)