Add plugin support and fix image size#162
Conversation
byrnHDF
added
Type - Improvement
Component - Build
|
The UserOption dialog for plugin path, should probably be converted to a list of the paths and allow the user to edit the list? |
… master-add-plugins
|
|
||
| pluginDir = ViewProperties.getPluginDir(); | ||
| if (pluginDir == null) | ||
| pluginDir = rootDir; |
There was a problem hiding this comment.
Should this be rootDir + "/plugin" to match the default in ViewProperties.java?
There was a problem hiding this comment.
Probably, it should just be a default if none are present, situation.
| currentDirButton.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false)); | ||
| currentDirButton.addSelectionListener(new SelectionAdapter() { | ||
| @Override | ||
| public void widgetSelected(SelectionEvent e) { |
There was a problem hiding this comment.
This should probably just let users select the plugin dir rather than a base directory. I think that will be confusing to a lot of people
There was a problem hiding this comment.
I have been thinking more about this, since this proof of implementation. It needs to be a list of paths and editable. At which time I think I will just drop that extra "/plugin" and require the real value.
2 participants
add user option entry for plugin path
add properties to save plugin path
appends path, but needs to be changed to replacing the path so every open table doesn't increase the number of path variables.
Address #117