Skip to content

Fix Family VFD filename conflict in tests #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Jul 17, 2025

test_dcpl_layout_caching() has been failing with the Family VFD ever since this test was added. The failure seems unrelated to the actual behavior change to the DCPL layout and instead related to conflicts between the user-provided filename and the filenames that the family VFD uses internally for its member files.

This avoids the problem for now by using slightly different filenames, but the family VFD issue should be investigated separately.


Important

Fix filename conflict in test_dcpl_layout_caching() in test/dsets.c by changing filename format and adding conditional resource closure.

  • Tests:
    • Fix filename conflict in test_dcpl_layout_caching() in test/dsets.c by changing src_fname format to %d%s%s.h5.
    • Add condition to close src_files and src_dsets only if layout_type is H5D_VIRTUAL.

This description was created by Ellipsis for 66499c7. You can customize this summary. It will automatically update as commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows
Projects
Status: To be triaged
Development

Successfully merging this pull request may close these issues.

1 participant