Skip to content

Add/update plugins examples #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Jul 15, 2025

fixes #5669


Important

Add Granular BitRound filter plugin example and update CMake and test configurations.

  • New Plugin Example:
    • Adds h5ex_d_granularbr.c to demonstrate Granular BitRound filter usage.
    • Updates CMakeLists.txt to include ENABLE_BITROUND option and add h5ex_d_granularbr to dyn_examples.
  • Testing:
    • Adds h5ex_d_granularbr.tst and h5ex_d_granularbr.ddl for testing the Granular BitRound filter.
    • Updates HDF5PluginCache.cmake to set ENABLE_BITROUND to OFF when H5PL_ALLOW_EXTERNAL_SUPPORT is GIT.
  • Misc:
    • Fixes whitespace in h5ex_d_bitgroom.tst.

This description was created by Ellipsis for af496f1. You can customize this summary. It will automatically update as commits are pushed.

file_id = -1;
status = H5close();
if (status < 0) {
printf("/nFAILED to close library/n");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error in the printf string: use "\n" instead of "/n". Change printf("/nFAILED to close library/n") to printf("\nFAILED to close library\n").

Suggested change
printf("/nFAILED to close library/n");
printf("\nFAILED to close library\n");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Misc Anything else (CODEOWNERS, etc.)
Projects
Status: To be triaged
Development

Successfully merging this pull request may close these issues.

Update plugins examples
2 participants