Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improved clarity #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rachclark
Copy link

Summary

Fixes #.

List of changes proposed in this PR (pull-request)

  • I modified text to try to improve clarity
  • I had a few moments of confusion and wanted to write a comment but was frustrated by the lack of ability to comment as I was making changes, so in some cases I just made the changes regardless of whether it was really what I thought was the best change.

@rachclark rachclark requested a review from jdkent as a code owner April 29, 2019 13:37
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files          18       18           
  Lines         806      806           
  Branches      119      119           
=======================================
  Hits          569      569           
  Misses        190      190           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb4f6d...c175649. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files          18       18           
  Lines         806      806           
  Branches      119      119           
=======================================
  Hits          569      569           
  Misses        190      190           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb4f6d...c175649. Read the comment docs.

@jdkent
Copy link
Member

jdkent commented May 3, 2019

Thanks for submitting this @rachclark! I'll probably merge this work in with the suggestions I received in person from the workshop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants