Debounce duplicate note popups #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modifier was originally written with the assumption that exactly one modifier controlled exactly one page. Of course, artists began using multiple Note Popup modifiers to show the same GUI page in multiple places. So, be sure that we only export the GUI objects once.
Fail fast if someone sets up multiple note popups with conflicting settings. This will allow us to obey the principle of least surprise.
|
While it didn't seem to fix the problem I had in Chiso (who knows what's going on there), I was able to get multiple clickables to point to the same GUI PRP without the client crashing this time in the test Kirel with Guild deco toggle, so the fix itself is sound. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405. Side effect: fixes potential error where generated objects crash when pre-exporting.
CC @DoobesURU