Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vertex colors to modulate lightmaps. #404

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Feb 3, 2024

Weird feature request by artists. Korman's lighting equation selection looks like it should work fine with this, though. The key is to be sure that we don't pick up a stale autocolor layer.

Fixes #403
Supersedes and closes #402

CC @DoobesURU

Weird feature request by artists. Korman's lighting equation selection
looks like it should work fine with this, though. The key is to be sure
that we don't pick up a stale autocolor layer.
@Hoikas Hoikas marked this pull request as ready for review February 3, 2024 20:57
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DoobesURU
Copy link
Contributor

DoobesURU commented Feb 3, 2024

Let me revert my hax and plug this in. I shall let you know.

EDIT: Nice! Appears to be working, at least on the Kirel private room floor:

Desktop Screenshot 2024 02 03 - 16 28 04 73

@Hoikas Hoikas merged commit 4414f2d into H-uru:master Feb 4, 2024
3 checks passed
@Hoikas Hoikas deleted the lm_vcol branch February 4, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to combine lightmaps and VCol layer
3 participants