Skip to content

Check before downloading gem #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

wildmaples
Copy link
Contributor

@wildmaples wildmaples commented May 21, 2025

Wait for rubygems to make new version available before running docker push.

Got a successful push: https://hub.docker.com/layers/gusto/buildkite-builder/4.18.0/images/sha256-e65226fd370c7a60b14b195d5c1ba494cf1a341a2bec18bf53ac2aab03915bf8

@wildmaples wildmaples requested a review from a team May 21, 2025 21:38
@noizwaves
Copy link

noizwaves commented May 21, 2025

@wildmaples this implementation is a bit unexpected. I'm wondering if there's a way for the image build step itself to block on the gem publish. Do you know where the gem publishing is happening?

If it's manual, we could extract this logic to a dedicated step, so it doesn't live inside the Dockerfile.

Dockerfile Outdated
Comment on lines 9 to 11
COPY .buildkite/docker/bootstrap /tmp/bootstrap
ARG version
RUN gem update --system --no-document && \
if [ -z "$version" ]; then \
gem install buildkite-builder; \
else \
gem install buildkite-builder -v "$version"; \
fi
RUN /tmp/bootstrap
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move ARG before COPY. Change to:

RUN /tmp/boostrap && rm -f /tmp/bootstrap

@wildmaples
Copy link
Contributor Author

@wildmaples this implementation is a bit unexpected. I'm wondering if there's a way for the image build step itself to block on the gem publish. Do you know where the gem publishing is happening?

If it's manual, we could extract this logic to a dedicated step, so it doesn't live inside the Dockerfile.

The gem publishing is happening in this script. The image build step to block on gem publish was my initial consideration but I opted for the looped retrying so we won't have to take the action to unblock twice in order to publish.

@wildmaples wildmaples requested a review from ngan May 22, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants