Do Not Merge: Make CopyToMap in Codegen a Hard Error.
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a GT4Py hack, because the Map have the wrong order and in GT4Py we do this explicitly before. This lead to bad code that will also refuse to launch for certain sizes.
This was referenced Jun 6, 2025
|
We could make this error configurable, as a config parameter of |
|
As I said, this silent promotion is an error and spotting it is difficult, thus allowing it to pass is bad. However, I agree that the proper way of merging that thing back to DaCe is most likely introducing this configuration parameter, but I do not have time to do that. |
|
This PR has been superseded by the PR#2033 in DaCe proper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several things here at play.
In normal GT4Py, we have to adjust the order of the Map iteration space, this is an artifact of the data layout that we are using, otherwise the strides are not correctly used (memory coalescence), this is why in GT4Py we are doing this by manually.
There is however also a different problem, that leads to launch errors.
Thus, we turn this silent "promotion" of Memlets into Maps into an hard error.
Note:
This fix (which in one way should enter DaCe main anyway) will render the GPU mode of DaCe unusable, at least outside GT4Py.