Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging development for wcci 2022 competition #50

Merged
merged 67 commits into from
Mar 16, 2022
Merged

Merging development for wcci 2022 competition #50

merged 67 commits into from
Mar 16, 2022

Conversation

BDonnot
Copy link
Collaborator

@BDonnot BDonnot commented Mar 14, 2022

Lots of changing in the core of chronix2grid

BDonnot and others added 22 commits March 3, 2022 15:47
Copy link
Collaborator Author

@BDonnot BDonnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes, looks good but I most likely did some weird stuff here

@BDonnot
Copy link
Collaborator Author

BDonnot commented Mar 14, 2022

Some unittests are broken:

FAILED tests/unit_tests/test_EconomicDispatch.py::TestDispatch::test_from_grid2op_env - grid2op.Exceptions.BackendExceptions.BackendEr...
FAILED tests/unit_tests/test_EconomicDispatch.py::TestDispatch::test_read_hydro_guide_curves - grid2op.Exceptions.BackendExceptions.Ba...
FAILED tests/unit_tests/test_EconomicDispatch.py::TestChronixScenario::test_net_load - AssertionError: 28.5 != 21.5
FAILED tests/unit_tests/test_grid2op_import.py::TestGrid2OpImport::test_grid2op_runner - grid2op.Exceptions.BackendExceptions.BackendE...
FAILED tests/unit_tests/test_load_coherence.py::TestLoadProdCoherence::test_load_coherence_year - AttributeError: module 'chronix2grid...
FAILED tests/unit_tests/test_main.py::TestMain::test_lrdk - AttributeError: 'float' object has no attribute 'shape'
FAILED tests/unit_tests/test_main.py::TestMain::test_lrdtk - AttributeError: 'float' object has no attribute 'shape'
FAILED tests/unit_tests/test_main.py::TestMain::test_lrk - AttributeError: 'float' object has no attribute 'shape'
FAILED tests/unit_tests/test_main.py::TestMain::test_lrtk - AttributeError: 'float' object has no attribute 'shape'

(9 failed, 21 passed, 13 warnings in 332.83s (0:05:32))

@BDonnot
Copy link
Collaborator Author

BDonnot commented Mar 16, 2022

Some KPI tests are broken, probably due to other pandas / numpy version, see below:

FAILED tests/unit_tests/test_main.py::TestMain::test_lrdtk - ValueError: x must be 1D
FAILED tests/unit_tests/test_main.py::TestMain::test_lrtk - ValueError: x must be 1D

I will not fix them.

@BDonnot BDonnot merged commit f50a5c2 into Grid2op:master Mar 16, 2022
@BDonnot
Copy link
Collaborator Author

BDonnot commented Mar 17, 2022

For the integration tests:

FAILED tests/integration_tests/test_integration.py::TestIntegration::test_integration_all - AssertionError: False is not true
FAILED tests/integration_tests/test_integration.py::TestIntegration::test_integration_lrt_nolosscorrection - AssertionError: False is not true
FAILED tests/integration_tests/test_integration.py::TestIntegration::test_integration_lrt_withlosscorrection - AssertionError: False is not true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants