Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mysql kvbackend #5528

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add mysql kvbackend #5528

wants to merge 9 commits into from
+761 −12

Conversation

CookiePieWw
Copy link
Collaborator

@CookiePieWw CookiePieWw commented Feb 13, 2025 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#5494

What's changed and what's your intention?

As title.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@CookiePieWw CookiePieWw requested review from MichaelScofield and a team as code owners February 13, 2025 08:37
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 13, 2025
@CookiePieWw CookiePieWw removed the request for review from MichaelScofield February 13, 2025 08:40
@CookiePieWw CookiePieWw force-pushed the mysql-kvbackend branch 2 times, most recently from 5328ee4 to 1dc0b04 Compare February 14, 2025 09:01
@CookiePieWw CookiePieWw changed the title [WIP]feat: add mysql kvbackend feat: add mysql kvbackend Feb 14, 2025
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Feb 14, 2025
@sunng87 sunng87 mentioned this pull request Feb 14, 2025
Open
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Feb 14, 2025
@CookiePieWw
Copy link
Collaborator Author

CookiePieWw commented Feb 17, 2025 •
edited
Loading

Bench results (roughly equals to postgresql before #5497 optim, seems we can also have a cached plan optim if possible.
image

fengjiachun
fengjiachun reviewed Feb 19, 2025
View reviewed changes
WenyXu
WenyXu reviewed Mar 4, 2025
View reviewed changes
src/common/meta/src/kv_backend/rds/mysql.rs
MySqlTemplateSet {
table_name: table_name.to_string(),
create_table_statement: format!(
"CREATE TABLE IF NOT EXISTS {table_name}(k VARBINARY(3072) PRIMARY KEY, v BLOB);",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is VARBINARY(3072) long enough

Copy link
Collaborator Author

@CookiePieWw CookiePieWw Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure actually. Do we need to have a look to the max length of all possible keys? It's the longest in mysql.

fengjiachun
fengjiachun reviewed Mar 6, 2025
View reviewed changes
src/common/meta/src/kv_backend/rds/mysql.rs
"CREATE TABLE IF NOT EXISTS {table_name}(k VARBINARY(3072) PRIMARY KEY, v BLOB);",
),
range_template: RangeTemplate {
point: format!("SELECT k, v FROM {table_name} WHERE k = ?"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
point: format!("SELECT k, v FROM {table_name} WHERE k = ?"),
point: format!("SELECT k, v FROM {table_name} WHERE k = ?;"),

Copy link
Collaborator Author

@CookiePieWw CookiePieWw Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we'll add some predicates to the end of the sql so that we cannot directly close it. Modified in cf98c50, test failed in f8c03d9 and revert in 309c001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun left review comments

@WenyXu WenyXu WenyXu left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CookiePieWw @fengjiachun @WenyXu