Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 compatibility #96

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Python 3 compatibility #96

wants to merge 22 commits into from

Conversation

AliciaSchep
Copy link
Contributor

Based on #95 but with a few small fixes, updated setup.py, and an added test case.

@AliciaSchep AliciaSchep mentioned this pull request Dec 20, 2020
Merged
@liz-is
Copy link

liz-is commented Aug 17, 2021

FWIW, I tried the py3 branch out on my data and it seems to work well. I didn't run the python 2 version to compare though.

The only thing I had to change was to add an extra import statement in bin/nucleoatac:

from multiprocessing import freeze_support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AliciaSchep @liz-is @oaxiom