Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trello in project #381

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

krshubham
Copy link
Contributor

No description provided.

@krshubham
Copy link
Contributor Author

This pull request refers to the work I have done for Trello Integration inside Teem! I will also be writing a couple of readme files here for more information!

@@ -60,6 +60,15 @@
return deferred.promise;
}

function archiveCard(trelloObj, need){
let deferred = $q.defer();
const archiveCardURL = `https://api.trello.com/1/cards/${need.trelloId}?closed="true"&key=09e4aced60041e389dbb27b9accadd65&token=${trelloObj.token}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key should go to the configuration file, and now be changed probably. Please let me know the new key so I can add it to the secrets file to be used by travis.

.catch(err => deferred.reject(result.data));
return deferred.promise;
}

function registerWebhook(trelloObj){
const webhookURL = `https://api.trello.com/1/webhooks/?idModel=${trelloObj.boardId}&key=09e4aced60041e389dbb27b9accadd65&token=${trelloObj.token}&callbackURL=http://13.126.145.126:9000/`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, key to config file.

@atfornes
Copy link
Contributor

When trying to add tasks using this code, either empty or preselecting some text I get the following error:
Cannot read property 'addEventListener' of null

comming from line: https://github.com/Grasia/teem/blob/master/src/js/services/pad/need-widget.js#L39

This commit does not touch that line,but somehow broke the behaviour. Please have a look to see if the issue can be fixed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants