Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader validation #5

Merged
merged 7 commits into from
Jul 10, 2022
Merged

Shader validation #5

merged 7 commits into from
Jul 10, 2022

Conversation

JuanDiegoMontoya
Copy link

@JuanDiegoMontoya JuanDiegoMontoya commented Jul 8, 2022

Validate everything to do with shaders and programs. Should implement #2 in the process.

@JuanDiegoMontoya JuanDiegoMontoya added the enhancement New feature or request label Jul 8, 2022
@JuanDiegoMontoya
Copy link
Author

This PR still needs some work. I just wanted to try this draft PR feature GitHub has.

Copy link
Contributor

@deccer deccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things up for discussion

include/gl_layer/private/context.h Outdated Show resolved Hide resolved
src/shader.cpp Outdated Show resolved Hide resolved
src/shader.cpp Show resolved Hide resolved
src/shader.cpp Outdated Show resolved Hide resolved
@JuanDiegoMontoya JuanDiegoMontoya marked this pull request as ready for review July 10, 2022 11:40
@JuanDiegoMontoya JuanDiegoMontoya merged commit 0454bc5 into master Jul 10, 2022
@JuanDiegoMontoya JuanDiegoMontoya deleted the shader-validation branch July 10, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants