Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set isEvalSupported to false #356

Closed
wants to merge 1 commit into from
Closed

Conversation

colleirose
Copy link
Contributor

This reduces attack surface and mitigates CVE-2024-4367

This reduces attack surface and mitigates CVE-2024-4367
@thestinger
Copy link
Member

@thestinger
Copy link
Member

We've never supported using eval for anything due to our Content-Security-Policy not allowing unsafe-eval. It would be fine to turn off eval at this layer in addition to the more reliable systemic disabling via Content-Security-Policy. We've regularly tested that pdf.js handles having it disabled via CSP. I don't think they used to have an option to disable it so we've always simply relied on the fact that they can handle it being disallowed as a whole and fall back to doing things another way.

We can disable their usage of eval in this more specific way too, but the commit message should note that it has always been disabled at another layer (CSP). It doesn't make sense to mention CVE-2024-4367 in this way since they fixed it through removing that functionality and it didn't impact us so we don't need to mitigate it as we have always prevented that class of vulnerability.

@thestinger
Copy link
Member

Included in #364.

@thestinger thestinger closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants