Add support for inner-background-color and inner-border-radius #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
reviewed
Jun 20, 2023
| @@ -111,7 +113,7 @@ export default (editor: grapesjs.Editor, { opt, coreMjmlModel, coreMjmlView, san | |||
| }, | |||
|
|
|||
| getChildrenSelector() { | |||
| return 'table'; | |||
| return 'table > tbody > tr > td > table'; | |||
There was a problem hiding this comment.
This seems to break the Column component
There was a problem hiding this comment.
Yes in order to inner background to work i need adjust the getChildrenSelector()
and i had check even with this change the background color will work as normal.
If you need i can provide the mjml code you need to compare
Thanks
There was a problem hiding this comment.
I'm just trying to load the default template and this is what I see
that means the output returned from mjml compiler doesn't match your new selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi i want to add support for the attribute inner-background-color and inner-border-radius for mj-column component
Now editor able to create this
@artf or @DRoet can check it?