Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includeln argument which includes method line number to frame #8

Merged

Conversation

mpozniak95
Copy link

Connected with: intel/gprofiler#799

@mpozniak95
Copy link
Author

GetLineNumberTable return line_number that is the first line in a method block f.e.:
For fibonacci
image
it returns line number 9. Is this ok, or should we change it to line_number - 1?

@Jongy
Copy link

Jongy commented Jul 4, 2023

GetLineNumberTable return line_number that is the first line in a method block f.e.: For fibonacci image it returns line number 9. Is this ok, or should we change it to line_number - 1?

Yes, that's good. The definittion is - the line of code that actually executes.

@Jongy Jongy merged commit 40b850a into Granulate:async-profiler-granulate Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants