Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color.calendar.scheduled to no-color.theme #3666

Merged

Conversation

d2718nis
Copy link
Contributor

@d2718nis d2718nis commented Nov 5, 2024

Issue

The built-in no-color.theme file lacks a color.calendar.scheduled setting, causing this color to remain active with the default settings rather than being reset.

screenshot-2024-11-05-14-22-25

There is a no-color.theme file that has no color at all, and while this sounds useless, it allows you to start with no color, and add your own. If you are building your own theme, this is what you would start with.

Documentation

Other considerations

It may be beneficial to add this setting to other built-in themes as well. However, including color.calendar.scheduled= directly would reset any color currently assigned by default. As an alternative, I could add a commented-out placeholder line # color.calendar.scheduled= to avoid interfering with existing color settings while providing a hint for future customization. Let me know if this approach would be useful.

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks good, but please do add it to the other themes as well.

Could it just be set to the default in those themes?

@d2718nis
Copy link
Contributor Author

d2718nis commented Nov 5, 2024

Done, added color.calendar.scheduled= to all themes which would reset the color to default foreground on background.

I also noticed that some of the colors are assigned during the default taskrc generation process. Maybe all color-related configuration entries should be moved to a default.theme file and just included via include default.theme?

@djmitche
Copy link
Collaborator

djmitche commented Nov 5, 2024

Done, added color.calendar.scheduled= to all themes which would reset the color to default foreground on background.

I also noticed that some of the colors are assigned during the default taskrc generation process. Maybe all color-related configuration entries should be moved to a default.theme file and just included via include default.theme?

That sounds like a good idea!

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djmitche djmitche merged commit 5b1be95 into GothenburgBitFactory:develop Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants