Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled attribute updated in handleRecurrence. #3006

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

scompo
Copy link

@scompo scompo commented Dec 9, 2022

Hi, I'm using the scheduled attribute in a recurring task, and noticed it's not updated when creating the next task.

I think it's a known problem, and related to #1534.

Description

I've handled the scheduled attribute in the same way of wait when handling the recurrence.
Just added the difference from the original due and scheduled to the new due date as the scheduled.

Additional information...

  • I've modified the C++ code but I'm not able to build the code on aarch64, so I haven't tested it.

The "scheduled" attribute of tasks generated by recurring tasks is now
updated the same way the "wait" attribute is handled.

The difference between the original "scheduled" and "due" dates is
added to the "due" date of each generated task when a "scheduled" date is
present.
@tbabej
Copy link
Sponsor Member

tbabej commented Dec 18, 2022

@scompo This looks good on my end. Do you think you could add support for the until attribute as well? That way we'd fully address the issue in #1534.

As far as the build failure on aarch64, could you perhaps open up a separate issue about that? We are striving to support multiple architectures, including this one.

@scompo
Copy link
Author

scompo commented Dec 19, 2022

@tbabej Sure, I'll look into updating the until flag too. From the documentation it looks like it should be updated the same as both wait and scheduled. Anything else I should worry about it when upgrading it?

As for for the compilation problem I'll open up a new issue with the error as soon as I'm able to

Updated the until attribute in a new recurring task being created adding
the time difference of the until date from the due date in the parent
task.
@djmitche djmitche requested a review from tbabej May 5, 2024 23:52
@djmitche
Copy link
Collaborator

djmitche commented May 5, 2024

@tbabej do you remember the status here? Was this worthwhile merging without the until support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants