chore: Release 2.18 - #10010
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares for the v2.18.0 release of Skaffold, focusing on essential maintenance and infrastructure updates. It incorporates significant Go version upgrades, addresses security concerns by updating the Docker CLI, and includes a broad range of dependency updates across the project. The changes also aim to improve CI/CD processes and enhance the stability of integration tests. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be for the v2.18.0 release. However, I've found a few changes that look like accidental reverts, resulting in downgrades of dependencies. Specifically, Flask is downgraded in one example, and in another, the Go version and several dependencies like golang.org/x/oauth2 are downgraded. These downgrades could reintroduce bugs or security vulnerabilities and contradict some of the updates listed in the CHANGELOG.md. Please review the specific comments for details.
| go.opencensus.io v0.24.0 // indirect | ||
| golang.org/x/net v0.38.0 // indirect | ||
| golang.org/x/oauth2 v0.27.0 // indirect | ||
| golang.org/x/oauth2 v0.7.0 // indirect |
There was a problem hiding this comment.
The golang.org/x/oauth2 dependency is being downgraded from v0.27.0 to v0.7.0. This is a significant downgrade that could reintroduce security vulnerabilities. The CHANGELOG.md entry for PR #9918 indicates this dependency was recently upgraded. This change appears to be an accidental revert.
| golang.org/x/oauth2 v0.7.0 // indirect | |
| golang.org/x/oauth2 v0.27.0 // indirect |
| @@ -1 +1 @@ | |||
| Flask==3.1.3 | |||
| Flask==3.1.0 | |||
There was a problem hiding this comment.
The Flask version is being downgraded from 3.1.3 to 3.1.0. This appears to be an accidental revert, as the CHANGELOG.md indicates an upgrade to 3.1.3 in PR #10006. Downgrading could reintroduce bugs or vulnerabilities. Please restore the version to 3.1.3.
Flask==3.1.3
| module github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/service | ||
|
|
||
| go 1.23.0 | ||
| go 1.19 |
There was a problem hiding this comment.
The Go version is being downgraded to 1.19, but the corresponding Dockerfiles (examples/grpc-e2e-tests/cloud-spanner-bootstrap/Dockerfile and examples/grpc-e2e-tests/service/Dockerfile) are being upgraded to use golang:1.23. For consistency, the go.mod should also specify a 1.23 version.
| go 1.19 | |
| go 1.23.0 |
2 participants
There will be a linter failure from hack/check-samples.sh. This is because it checks for the latest schema version in the most recent release. Since you haven't released this schema version yet, it will incorrectly say that you're using the wrong version. You can ignore this failure.