This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Fix caching for empty RUNs #3496
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the output of kaniko differs whether we have build from scratch or from cache. When we build from scratch we omit empty layers created by pointless RUN statements. When we then rebuild from cache we do emit layers for them. This can cause further cache misses if the empty RUN statement is in a base image of a multistage build.
first run (from scratch):
second run (from cache):
Interestingly we here mimic the behaviour of legacy docker and this is enforced by integration-tests. buildkit does no longer optimize out empty RUN statements.
With this change we now make behaviour consistent whether we build from scratch or from cache.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes