Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to skip update checks from pom properties #4212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmannibucau
Copy link
Contributor

@rmannibucau rmannibucau commented Mar 18, 2024

Follow up of #3350 (comment) since it is really bothering to not be able to disable update check for project in time - when you don't work on a single "everyday" project and disabling it globally is rarely the desired behavior (it is really a per project thing) but the properties were not read as expected so this PR ensures it is the case.

Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.

Please follow the guidelines below before opening an issue or a PR:

  • Ensure the issue was not already reported.
  • Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose if you are unable to find an existing issue addressing your problem. Make sure to include a title and clear description, as much relevant information as possible, and a code sample or an executable test case demonstrating the expected behavior that is not occurring.
  • Discuss the priority and potential solutions with the maintainers in the issue. The maintainers would review the issue and add a label "Accepting Contributions" once the issue is ready for accepting contributions.
  • Open a PR only if the issue is labeled with "Accepting Contributions", ensure the PR description clearly describes the problem and solution. Note that an open PR without an issues labeled with "Accepting Contributions" will not be accepted.
  • Verify that integration tests and unit tests are passing after the change.
  • Address all checkstyle issues. Refer to the style guide.

Fixes #<issue_number_goes_here> 🛠️

@rmannibucau rmannibucau force-pushed the rmannibucau/disable-updatecheck-from-pom branch from 5e8a94e to a493114 Compare March 18, 2024 18:15
@rmannibucau rmannibucau force-pushed the rmannibucau/disable-updatecheck-from-pom branch from a493114 to a486403 Compare March 18, 2024 18:22
@slawekjaranowski
Copy link

even more there is the problem to settings environment variable with dots like jib.disableUpdateChecks on unix systems

I have tested with zsh and bash on macOs ...

zsh

export jib.disableUpdateChecks=true 
export: not valid in this context: jib.disableUpdateChecks

bash

export jib.disableUpdateChecks=true
bash: export: `jib.disableUpdateChecks=true': not a valid identifier

so I can not disable it at easy way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants