Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigquery-connection): supply a manual connection_id to assist with cleanup #11721

Merged
merged 4 commits into from May 10, 2024

Conversation

tswast
Copy link
Contributor

@tswast tswast commented May 7, 2024

Description

Fixes #11720

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@tswast tswast requested review from a team as code owners May 7, 2024 16:07
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 7, 2024
@tswast tswast changed the title docs: supply a manual connection_id to assist with cleanup docs(bigquery-connection): supply a manual connection_id to assist with cleanup May 8, 2024
@tswast
Copy link
Contributor Author

tswast commented May 9, 2024

Note: When you look at the cloud console now, the connections have been cleaned up because I added some generic cleanup code in

https://github.com/googleapis/python-bigquery-dataframes/blob/57ccabcd1402b7938e2c7068e5b4880ef018f39c/samples/snippets/remote_function_test.py#L24-L50

but I'd like to remove that code once the source of the stray connections has been fixed.

@leahecole leahecole merged commit 70d8352 into main May 10, 2024
15 checks passed
@leahecole leahecole deleted the tswast-bq-connection branch May 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Connections code sample is not cleaning up after itself
4 participants