Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter manager regional parameter resource google_parameter_manager_regional_parameter #12631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abheda-crest
Copy link
Contributor

Add support for new parameter manager regional parameter resource google_parameter_manager_regional_parameter.

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_regional_parameter`

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 20, 2024
@abheda-crest
Copy link
Contributor Author

This PR targets to add regional support for Parameter Manager Parameter resource which is targetted in the branch: #12630

@abheda-crest abheda-crest marked this pull request as ready for review December 20, 2024 11:50
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau December 20, 2024 11:51
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1248 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1238 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 324 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4386
Passed tests: 3948
Skipped tests: 429
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccParameterManagerRegionalRegionalParameter_import
  • TestAccParameterManagerRegionalRegionalParameter_labelsUpdate
  • TestAccParameterManagerRegionalRegionalParameter_regionalParameterBasicExample
  • TestAccParameterManagerRegionalRegionalParameter_regionalParameterWithFormatExample
  • TestAccParameterManagerRegionalRegionalParameter_regionalParameterWithLabelsExample
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccParameterManagerRegionalRegionalParameter_import [Debug log]
TestAccParameterManagerRegionalRegionalParameter_labelsUpdate [Debug log]
TestAccParameterManagerRegionalRegionalParameter_regionalParameterBasicExample [Debug log]
TestAccParameterManagerRegionalRegionalParameter_regionalParameterWithFormatExample [Debug log]
TestAccParameterManagerRegionalRegionalParameter_regionalParameterWithLabelsExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@abheda-crest
Copy link
Contributor Author

@BBBmau Let's just hold this PR as it is dependent on the PR #12630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants