Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark vcenter field in VMware cluster resource as default from api #12624

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

naitianliu-google
Copy link
Contributor

@naitianliu-google naitianliu-google commented Dec 19, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gkeonprem: fixed by marking `vcenter` field in `google_gkeonprem_vmware_cluster` as default from api to ignore the diffs for update

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+))
google-beta provider: Diff ( 1 file changed, 8 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • gkeonprem

🟢 All tests passed!

View the build log

Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants