feat(agent): add "enable-confirmations" meta-command to undo "don't ask me again" - #681
Open
PratikDhanave wants to merge 1 commit into
Open
Conversation
…sk me again" After choosing "Yes, and don't ask me again" at a confirmation prompt, SkipPermissions is set for the rest of the session with no way to turn confirmations back on without restarting. Add an `enable-confirmations` meta-command that clears SkipPermissions so the agent resumes asking before commands that modify resources. Idempotent when confirmations are already on. Fixes GoogleCloudPlatform#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
enable-confirmationsmeta-command that turns action confirmations back on after the user selected "Yes, and don't ask me again".Why
Fixes #305. Selecting "Yes, and don't ask me again" at a confirmation prompt sets
SkipPermissions = truefor the rest of the session (pkg/agent/conversation.go), and there was no way to undo it short of restartingkubectl-ai. This adds a first-class way to re-enable the safety prompts mid-session.Change
New case in
handleMetaQuery:SkipPermissions, so the agent resumes prompting before resource-modifying commands.Testing
Adds
TestHandleMetaQuery_EnableConfirmations(covers the toggle-off and the already-enabled/idempotent path).go build,go vet, andgo test ./pkg/agent/pass.