fix(agent): extract JSON from a bare fence, not only json - #680
Open
PratikDhanave wants to merge 1 commit into
Open
fix(agent): extract JSON from a bare fence, not only json#680PratikDhanave wants to merge 1 commit into
fence, not only json#680PratikDhanave wants to merge 1 commit into
Conversation
parseReActResponse (used by the tool-use shim for models without native function calling) relies on extractJSON, which only recognized a ```json fence. Models frequently emit the JSON in a bare ``` block with no language tag, in which case extraction returned false and the whole turn failed to parse. Fall back to a bare ``` fence when ```json is absent. The ```json path is unchanged. Adds table tests for extractJSON and parseReActResponse (previously untested), covering the ```json fence, the bare ``` fence, and no-fence/invalid inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the tool-use-shim response parser tolerant of a bare
```code fence, not only```json. Adds unit tests for the (previously untested)extractJSONandparseReActResponsehelpers.Why
For models without native function-calling, kubectl-ai uses a ReAct-style shim and parses the model's JSON out of a fenced code block via
extractJSON:It only recognized
```json. But models frequently emit the JSON in a bare```block (no language tag). In that caseextractJSONreturnedfalse,parseReActResponseerrored, and the whole turn failed — even though the model produced a perfectly valid action.Change
extractJSONnow falls back to a bare```fence when```jsonis absent. The```jsonpath is unchanged (byte-for-byte), so existing behavior is preserved; this only adds a fallback.Testing
Adds
TestExtractJSONandTestParseReActResponse(these helpers had no tests) covering thejsonfence, the new bare fence, and no-fence / invalid-JSON inputs.go test ./pkg/agent/andgo vetpass.