feat: expose --log_file flag to customize the log destination - #679
Open
PratikDhanave wants to merge 1 commit into
Open
feat: expose --log_file flag to customize the log destination#679PratikDhanave wants to merge 1 commit into
PratikDhanave wants to merge 1 commit into
Conversation
The klog log_file was hard-set to <tmpdir>/kubectl-ai.log and never surfaced to users. Expose it as a persistent flag (the same way `v` and `alsologtostderr` are already exposed) so the log path is configurable; the default is unchanged, and `--log_file=/dev/null` disables file logging. Fixes GoogleCloudPlatform#428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exposes the klog
log_fileflag so users can customize wherekubectl-aiwrites its log, instead of it always being<tmpdir>/kubectl-ai.log.Why
Fixes #428. The log destination was hard-set in
cmd/main.go:…but the
log_fileflag was never added to the command, so there was no way to change it.vandalsologtostderrare already surfaced the same way; this just addslog_filealongside them.Change
<tmpdir>/kubectl-ai.log).--log_file=/path/to/kubectl-ai.log, or--log_file=/dev/nullto disable file logging (as the issue requests).Testing
go build ./...andgo vet ./...pass.kubectl-ai --helpnow lists: