Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(livestream): add VOD clip samples and test #9597

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Oct 21, 2024

Description

Fixes b:341726237

Important: FFmpeg (https://www.ffmpeg.org/) must be installed in the test environment.

sudo apt install ffmpeg

Will update the other samples to the latest sample guidelines in a follow up PR.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Please merge this PR for me once it is approved

@irataxy irataxy requested review from yoshi-approver and a team as code owners October 21, 2024 23:23
@product-auto-label product-auto-label bot added api: livestream Issues related to the Live Stream API API. samples Issues that are directly related to samples. labels Oct 21, 2024
Copy link

snippet-bot bot commented Oct 21, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@irataxy irataxy marked this pull request as draft October 31, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: livestream Issues related to the Live Stream API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants