Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(speech): Add speech StreamingRecognize samples #3753

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

shubhamkr619
Copy link

@shubhamkr619 shubhamkr619 commented Jan 22, 2024

Description

Added support to stt v2 apis for livecaption and livecaption_from_file. Missing for a customer to follow with samples.

Fixes #3754 Required the support the stt_v2 apis

Feat # Add support for stt v2 apis

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [*] I have followed Contributing Guidelines from CONTRIBUTING.MD
  • [*] Tests pass: go test -v ./.. (see Testing)
  • [*] Code formatted: gofmt (see Formatting)
  • [*] Vetting pass: go vet (see Formatting)
  • [*] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [*] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [*] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [*] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [*] Please merge this PR for me once it is approved

@shubhamkr619 shubhamkr619 requested review from a team as code owners January 22, 2024 14:31
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 22, 2024
Copy link

snippet-bot bot commented Jan 22, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@nitsanshai
Copy link

These should be in the snippets/ folder, similar to the others: https://github.com/GoogleCloudPlatform/golang-samples/tree/main/speech/snippets

And can you make them analogous to the python samples? https://github.com/GoogleCloudPlatform/python-docs-samples/tree/196be7a900be64ed5429a17f07e28ac255e20642/speech/snippets

@hpkaur86
Copy link
Contributor

Thanks Shubham and Kodanda for implementing on the ask and creating the PR. I am working with product team to merge the same.

@hpkaur86
Copy link
Contributor

@nitsanshai Thank you for the review. Working on it.

@shubhamkr619
Copy link
Author

shubhamkr619 commented Jan 22, 2024 via email

@shubhamkr619
Copy link
Author

@nitsanshai , as per your suggestion code has been changed. Please review the same.

@nitsanshai
Copy link

Can you change the PR name to:
docs(samples): speech StreamingRecognize samples

@shubhamkr619 shubhamkr619 changed the title feat: add support to speech v2 for livecaption and livecaption_from_file docs(samples): speech StreamingRecognize samples Feb 5, 2024
@muncus muncus self-assigned this Feb 7, 2024
Copy link
Collaborator

@muncus muncus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since they are so similar, please address the comments on transcribe_streaming_v2 in the explicit decoding sample as well. Thanks!

speech/snippets/transcribe_streaming_v2.go Outdated Show resolved Hide resolved
speech/snippets/transcribe_streaming_v2.go Outdated Show resolved Hide resolved
speech/snippets/transcribe_streaming_v2.go Outdated Show resolved Hide resolved
speech/snippets/transcribe_streaming_v2.go Outdated Show resolved Hide resolved
speech/snippets/transcribe_streaming_v2.go Show resolved Hide resolved
speech/snippets/transcribe_streaming_v2.go Show resolved Hide resolved
@grayside grayside changed the title docs(samples): speech StreamingRecognize samples feat(speech): Add speech StreamingRecognize samples Feb 20, 2024
@shubhamkr619
Copy link
Author

shubhamkr619 commented Mar 4, 2024

@muncus , please review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Required the support the stt_v2 apis
5 participants