Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use out.String() instead of string(out.Bytes()) #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

chore: use out.String() instead of string(out.Bytes()) #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a66ca
chore: use out.String() instead of string(out.Bytes())
testwill Aug 31, 2023
8a528b3
Merge branch 'master' into string
brandonmichigangithub Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func TestConfigureDocker(t *testing.T) {
helper.Stdout = &out
helper.Stderr = os.Stderr
if err = helper.Run(); err != nil {
t.Fatalf("Failed to execute `configure-docker --overwrite`: %v Stdout: %s", err, string(out.Bytes()))
t.Fatalf("Failed to execute `configure-docker --overwrite`: %v Stdout: %s", err, out.String())
}

dockerConfig, err = getDockerConfig()
Expand Down Expand Up @@ -156,7 +156,7 @@ func TestConfigureDocker_NonDefault(t *testing.T) {
helper.Stdout = &out
helper.Stderr = os.Stderr
if err = helper.Run(); err != nil {
t.Fatalf("Failed to execute `configure-docker --overwrite`: %v Stdout: %s", err, string(out.Bytes()))
t.Fatalf("Failed to execute `configure-docker --overwrite`: %v Stdout: %s", err, out.String())
}

dockerConfig, err = getDockerConfig()
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func TestEndToEnd_GCRCreds(t *testing.T) {
helper.Stdout = &out
helper.Stdin = strings.NewReader(gcrRegistry)
if err = helper.Run(); err != nil {
t.Fatalf("`get` failed: %v, Stdout: %s", err, string(out.Bytes()))
t.Fatalf("`get` failed: %v, Stdout: %s", err, out.String())
}

// Verify the credentials
Expand Down
Loading