fixed complex_rule_validation_success_flag (#217)

GoogleCloudPlatform · Jan 11, 2023 · 2539d80 · 2539d80
1 parent ee8e326
commit 2539d80
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 34 deletions.
diff --git a/clouddq/templates/dbt/macros/macros.sql b/clouddq/templates/dbt/macros/macros.sql
@@ -69,7 +69,7 @@
     TRUE AS skip_null_count,
     custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
     CASE
-      WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+      WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
       WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
       ELSE FALSE
     END AS complex_rule_validation_success_flag,
@@ -149,7 +149,7 @@
     TRUE AS skip_null_count,
     custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
     CASE
-      WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+      WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
       WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
       ELSE FALSE
     END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/bq_native_default_partitioned_sql_expected.sql b/tests/resources/bq_native_default_partitioned_sql_expected.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/bq_native_partitioned_sql_expected.sql b/tests/resources/bq_native_partitioned_sql_expected.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/dataplex_gcs_metadata_sql_expected.sql b/tests/resources/dataplex_gcs_metadata_sql_expected.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/dataplex_gcs_partitioned_metadata_sql_expected.sql b/tests/resources/dataplex_gcs_partitioned_metadata_sql_expected.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/dataplex_metadata_configs_file_sql_expected.sql b/tests/resources/dataplex_metadata_configs_file_sql_expected.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/dataplex_metadata_sql_expected.sql b/tests/resources/dataplex_metadata_sql_expected.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ custom_sql_statement_validation_errors,
  TRUE AS skip_null_count,
  custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
  CASE
- WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+ WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
  WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
  ELSE FALSE
  END AS complex_rule_validation_success_flag,

diff --git a/tests/resources/dq_advanced_rules_expected_results.json b/tests/resources/dq_advanced_rules_expected_results.json
@@ -22,7 +22,7 @@
     "progress_watermark": true,
     "rows_validated": 100,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -36,7 +36,7 @@
     "progress_watermark": true,
     "rows_validated": 100,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -64,7 +64,7 @@
     "progress_watermark": true,
     "rows_validated": 86,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -134,7 +134,7 @@
     "progress_watermark": true,
     "rows_validated": 4002,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -148,7 +148,7 @@
     "progress_watermark": true,
     "rows_validated": 4002,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -176,7 +176,7 @@
     "progress_watermark": true,
     "rows_validated": 4002,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -190,7 +190,7 @@
     "progress_watermark": true,
     "rows_validated": 4002,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -204,7 +204,7 @@
     "progress_watermark": true,
     "rows_validated": 4002,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -442,7 +442,7 @@
     "progress_watermark": true,
     "rows_validated": 99,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -456,7 +456,7 @@
     "progress_watermark": true,
     "rows_validated": 99,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -484,7 +484,7 @@
     "progress_watermark": true,
     "rows_validated": 99,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -512,7 +512,7 @@
     "progress_watermark": true,
     "rows_validated": 99,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -554,7 +554,7 @@
     "progress_watermark": true,
     "rows_validated": 99,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null
@@ -568,7 +568,7 @@
     "progress_watermark": true,
     "rows_validated": 99,
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": 0,
     "failed_count": 0,
     "null_count": null

diff --git a/tests/resources/dq_rules_expected_results.json b/tests/resources/dq_rules_expected_results.json
@@ -78,7 +78,7 @@
     "progress_watermark": true,
     "rows_validated": "7",
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": "0",
     "failed_count": "0",
     "null_count": null
@@ -120,7 +120,7 @@
     "progress_watermark": true,
     "rows_validated": "9",
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": "0",
     "failed_count": "0",
     "null_count": null
@@ -148,7 +148,7 @@
     "progress_watermark": true,
     "rows_validated": "0",
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": null,
     "failed_count": null,
     "null_count": null
@@ -162,7 +162,7 @@
     "progress_watermark": true,
     "rows_validated": "0",
     "complex_rule_validation_errors_count": null,
-    "complex_rule_validation_success_flag": null,
+    "complex_rule_validation_success_flag": true,
     "success_count": null,
     "failed_count": null,
     "null_count": null

diff --git a/tests/resources/test_render_run_dq_main_sql_expected_custom_sql_statement.sql b/tests/resources/test_render_run_dq_main_sql_expected_custom_sql_statement.sql
@@ -45,7 +45,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,
@@ -82,7 +82,7 @@ CAST(NULL AS BOOLEAN) AS simple_rule_row_is_valid,
 TRUE AS skip_null_count,
 custom_sql_statement_validation_errors.complex_rule_validation_errors_count AS complex_rule_validation_errors_count,
 CASE
-WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN CAST(NULL AS BOOLEAN)
+WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count IS NULL THEN TRUE
 WHEN custom_sql_statement_validation_errors.complex_rule_validation_errors_count = 0 THEN TRUE
 ELSE FALSE
 END AS complex_rule_validation_success_flag,