-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to Cloud SQL Proxy v2 #1708
Conversation
170ab58
to
6ccd12d
Compare
@arueth currently (or at least last I tried), Bank of Anthos could juuuust fit in a 3-node default config GKE Standard cluster. This PR bumps a lot of requests upwards (sometimes 2x or 3x). What do you think is the new requirement if deploying in a GKE Standard cluster with these changes? |
We could create a "minimal" skaffold profile if we wanted to get really lean. |
The reason I mention this is because there's a lot of learning content that leverages Bank of Anthos' default configs which still uses GKE Standard with a limited # of nodes (e.g. 3 or 4). If we bump the default base requests that may break that learning content. For example, this tutorial deploys default Bank of Anthos on a 4-node cluster: https://cloud.google.com/migrate/containers/docs/migrating-monolith-vm-overview-setup#deploy You can see a more complete list here: go/boa-usage (internal) What do you think? |
Are the skaffold changes and kubernetes-manifests folders kept synchronized? I believe the vast majority of tutorials outside of the docs in the repo use the kubernetes-manifests folder, is that correct? |
Correct! 90+% of tutorials don't use kustomize / skaffold, they just The sync is made at release time (new release of Bank of Anthos) where we |
Would you prefer I move these changes out to a separate autopilot profile or only apply them to the staging/production profiles? It looks like the |
Yes, How about we make the higher-resources-requests changes on the staging/production profiles like you're suggesting? That way the development profile (and by extension, the generated "barebones" k8s manifests) stay minimal |
Since the Autopilot minimums are going to change, I'm changing this to only include the Cloud SQL Proxy v2 changes. |
6aea7d9
to
20c35ea
Compare
6f741b5
to
5b73b9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Background/Change Summary
Testing Procedure
Tested in my project using https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/main/docs/ci-cd-pipeline.md