-
Notifications
You must be signed in to change notification settings - Fork 472
Register visibility-change early #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tunetheweb
wants to merge
11
commits into
main
Choose a base branch
from
early-visibility-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
requested changes
Jul 15, 2025
tunetheweb
commented
Jul 16, 2025
philipwalton
requested changes
Jul 16, 2025
I got bored of manually testing this each time so added a test case. Despite my worries in the original comment it wasn't too bad to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502
@philipwalton I did what you suggested in #502 (comment) but I've a couple of observations/questions:
Code LocationAs the visibility-change event handlers are registered and unregistered after first page hide, we don't actually end up using any of the existing
getVisibilityWatcher
code. Additionally the only two functions that need this (onCLS
andonINP
) don't even import that at present. So not sure the code really lives best in here, or if it should just be in it's own./lib/onHidden.js
file? Then again, it might makegetVisibilityWatcher
more accurately name by putting it in this file (otherwise it maybe really should be calledgetInitHiddenTime
)!Update: Agreed it would go here.
Test caseShould we add a test case for this? Ideally yes of course, and it's possible to set up the test case similar to those reported (for example: old and new), but it would be a fair bit of extra code to add to the test suite, potentially complicating the existing test cases. And we don't have test cases for other such issues (though probably should, and maybe more so in this case since it's affected at least one user). Can you see an easy way to add a test case for this? Maybe as a unit test?
Update: Added a test case.