Skip to content

Register visibility-change early #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jul 15, 2025

Fixes #502

@philipwalton I did what you suggested in #502 (comment) but I've a couple of observations/questions:

Code Location
As the visibility-change event handlers are registered and unregistered after first page hide, we don't actually end up using any of the existing getVisibilityWatcher code. Additionally the only two functions that need this (onCLS and onINP) don't even import that at present. So not sure the code really lives best in here, or if it should just be in it's own ./lib/onHidden.js file? Then again, it might make getVisibilityWatcher more accurately name by putting it in this file (otherwise it maybe really should be called getInitHiddenTime)!

Update: Agreed it would go here.

Test case
Should we add a test case for this? Ideally yes of course, and it's possible to set up the test case similar to those reported (for example: old and new), but it would be a fair bit of extra code to add to the test suite, potentially complicating the existing test cases. And we don't have test cases for other such issues (though probably should, and maybe more so in this case since it's affected at least one user). Can you see an easy way to add a test case for this? Maybe as a unit test?

Update: Added a test case.

@tunetheweb tunetheweb requested a review from philipwalton July 15, 2025 20:44
@tunetheweb tunetheweb requested a review from philipwalton July 16, 2025 19:38
@tunetheweb
Copy link
Member Author

I got bored of manually testing this each time so added a test case. Despite my worries in the original comment it wasn't too bad to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clarification regarding event listener in event batching section
2 participants