Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deprecationDialog to redirect NGW modal #4321

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Oct 23, 2024

Description

Targeted Android users will now be shown a blocking modal, which guides them to the new goodwallet.

About # (link your issue here)
#4318

todo:

  • - add feature-flag
  • - confirm design

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goodwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 4:52pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 4:52pm
goodid ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 4:52pm

@L03TJ3 L03TJ3 marked this pull request as ready for review November 4, 2024 16:39
@L03TJ3 L03TJ3 merged commit 89cea0f into master Nov 4, 2024
4 of 18 checks passed
@L03TJ3 L03TJ3 deleted the 4318-ngw-android-modal branch November 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants