Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-verification screen #4303

Merged
merged 5 commits into from
Oct 7, 2024
Merged

re-verification screen #4303

merged 5 commits into from
Oct 7, 2024

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Sep 25, 2024

Description

This adds an alternative/new screen for when an existing user needs to redo the face-verification.

What works

  • web
  • android: not fully confirmed because of goodid pending fixes breaking the flow to the face-verification
    (but should not encounter issues as not much changed ui-wise)

What needs to be decided on:

  1. What for gooddapp users?
    -- Current flow skips the intro-screen. do we keep that flow?

Technical consideration:
I believe the decision was made to skip/jump over the intro screen because of wallet-specific logic.

if we keep the same flow as now > this PR can be merged.
if we need to show the screen to gooddapp users > that needs to be fixed still @sirpy

About # (link your issue here)
#4302

@L03TJ3 L03TJ3 requested a review from sirpy September 25, 2024 18:22
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goodwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:55pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:55pm
goodid ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 4:55pm

@decentralauren
Copy link

@L03TJ3 @sirpy yes, we should also show this screen in GoodDapp considering the % of GoodDapp users (e.g. Minipay users) this will affect. Please let me know if you need any more guidance.

Copy link
Contributor

@sirpy sirpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the standalone fv process for gooddapp uses the same screens, so i'm not sure anything needs to be updated for gooddapp.
  2. can you point to why you think for android we dont show the intro screen?

src/components/faceVerification/screens/IntroScreen.jsx Outdated Show resolved Hide resolved
src/components/faceVerification/screens/IntroScreen.jsx Outdated Show resolved Hide resolved
@L03TJ3 L03TJ3 changed the title wip: re-verification screen re-verification screen Oct 1, 2024
@L03TJ3 L03TJ3 requested a review from sirpy October 1, 2024 18:48
@L03TJ3 L03TJ3 merged commit 2e5e2ed into master Oct 7, 2024
6 of 19 checks passed
@L03TJ3 L03TJ3 deleted the face-verification-expired branch October 7, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants