-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-verification screen #4303
Merged
Merged
re-verification screen #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
sirpy
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the standalone fv process for gooddapp uses the same screens, so i'm not sure anything needs to be updated for gooddapp.
- can you point to why you think for android we dont show the intro screen?
sirpy
requested changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an alternative/new screen for when an existing user needs to redo the face-verification.
What works
(but should not encounter issues as not much changed ui-wise)
What needs to be decided on:
-- Current flow skips the intro-screen. do we keep that flow?
Technical consideration:
I believe the decision was made to skip/jump over the intro screen because of wallet-specific logic.
if we keep the same flow as now > this PR can be merged.
if we need to show the screen to gooddapp users > that needs to be fixed still @sirpy
About # (link your issue here)
#4302