4127: send to address #4137
Merged
4127: send to address #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@johnsmith-gooddollar @sirpy |
johnsmith-gooddollar
requested changes
Nov 18, 2023
| @@ -21,6 +21,7 @@ const InputText = ({ | |||
| adornmentStyle, | |||
| adornmentColor, | |||
| adornmentDisabled = false, | |||
| iconAlignment = 'right', | |||
There was a problem hiding this comment.
1, what have you decided about both paste + scan QR options ?
in this case you need to display 2 icon buttons somehow - need to discuss this
- you have repeated code. optimise it at leas by using useMemo:
const adornmentJsx = useMemo(() => showAdornment ? (
<TouchableOpacity style={[styles.adornment, adornmentStyle]} disabled={adornmentDisabled} onPress={_onPress}>
<Icon size={normalize(adornmentSize)} color={adornmentColor || inputColor} name={adornment} />
</TouchableOpacity>
) : null, [styles, adornmentStyle, adornmentDisabled, _onPress, adornmentSize, adornmentColor, inputColor, adornment])
Comment on lines
80
to
84
| {showAdornment && iconAlignment === 'left' && ( | ||
| <TouchableOpacity style={[styles.adornment, adornmentStyle]} disabled={adornmentDisabled} onPress={_onPress}> | ||
| <Icon size={normalize(adornmentSize)} color={adornmentColor || inputColor} name={adornment} /> | ||
| </TouchableOpacity> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {showAdornment && iconAlignment === 'left' && ( | |
| <TouchableOpacity style={[styles.adornment, adornmentStyle]} disabled={adornmentDisabled} onPress={_onPress}> | |
| <Icon size={normalize(adornmentSize)} color={adornmentColor || inputColor} name={adornment} /> | |
| </TouchableOpacity> | |
| )} | |
| {iconAlignment === 'left' && adornmentJsx} |
Comment on lines
93
to
96
| {showAdornment && error !== '' && iconAlignment === 'right' && ( | ||
| <TouchableOpacity style={[styles.adornment, adornmentStyle]} disabled={adornmentDisabled} onPress={_onPress}> | ||
| <Icon size={normalize(adornmentSize)} color={adornmentColor || inputColor} name={adornment} /> | ||
| </TouchableOpacity> |
There was a problem hiding this comment.
Suggested change
| {showAdornment && error !== '' && iconAlignment === 'right' && ( | |
| <TouchableOpacity style={[styles.adornment, adornmentStyle]} disabled={adornmentDisabled} onPress={_onPress}> | |
| <Icon size={normalize(adornmentSize)} color={adornmentColor || inputColor} name={adornment} /> | |
| </TouchableOpacity> | |
| {error !== '' && iconAlignment === 'right' && adornmentJsx} |
| disabled={loading} | ||
| {...props} | ||
| /> | ||
| {isSend && ( |
There was a problem hiding this comment.
have you tested it with the native flow ? set REACT_APP_DELTA=true in Your local env, at dev instance you will be able to switch onto Goerli and select gEth to send. If you need some Goerli pls ask me
There was a problem hiding this comment.
yes I did test, have not tested sending any funds yet tho. will do
|
@L03TJ3 make sure unit tests are passing |
|
@L03TJ3 regarding input with 2 icons
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was already implemented, but not used. so here we enable the UI so that users can send their g$'s directly to an addres
finalize UI points:
About # (link your issue here)
#4127
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: