Prepend the object path to .o files in generated dependency rules. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The makefile was generating dependency rules which did not include the directory part of the object filenames. This caused a problem where the project would not be rebuilt if only the header files changed. This commit fixes that by correctly specifying the name of the object files in the dependency generation rule. At the same time, it simplifies the dependency generation rule, by passing extra options to the compiler so it generates the exact file we want. This means we no longer need to use sed to rewrite the dependency files. This addresses Golevka#40.
|
Sorry, I just realized I didn't use the correct syntax in my commit message to close the issue when you pull the commit. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makefile was generating dependency rules which did not include the directory
part of the object filenames. This caused a problem where the project would not
be rebuilt if only the header files changed.
This commit fixes that by correctly specifying the name of the object files in
the dependency generation rule. At the same time, it simplifies the dependency
generation rule, by passing extra options to the compiler so it generates the
exact file we want. This means we no longer need to use sed to rewrite the
dependency files.
This addresses #40.