Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better profiles #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better profiles #79

wants to merge 3 commits into from

Conversation

pix
Copy link
Contributor

@pix pix commented Sep 14, 2017

  Now creates a directory in the cache directory. Every file is moved
  under that temp directory. It should allow packer to build multiple
  machines concurently
@obilodeau
Copy link
Member

I'm just starting to review it but I wanted to say upfront:

Added a subfolder to the .cache directory to allow concurrent builds.

👍 to that! I meant to do that. Thanks!

@obilodeau
Copy link
Member

I think choco_packages should stay and that profiles packages should be added on top. For simplicity, it can be done in two different steps, it's not important.

@pix
Copy link
Contributor Author

pix commented Sep 26, 2017

I can do it, however, as I said in another thread, wouldn't it be cool if we could generate kali vm with malboxes, if so, choco_packages should be at least renamed to packages ?

@obilodeau
Copy link
Member

if so, choco_packages should be at least renamed to packages ?

I agree but let's support choco_packages for a while to give time to people to upgrade their configs. Remove it from example config but in the code if there is no packages entry, honor the choco_packages entry if it exists.

@obilodeau
Copy link
Member

I'm running a test dry-run build on all supported OSes with that branch right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants