[gnc-date.cpp] deprecate gnc_difftime

because it casts time64 to doubles
Gnucash · Sep 8, 2024 · d935ede · d935ede
1 parent 9c4ef93
commit d935ede
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/libgnucash/engine/gnc-date.cpp b/libgnucash/engine/gnc-date.cpp
@@ -270,6 +270,7 @@ gnc_time (time64 *tbuf)
 gdouble
 gnc_difftime (const time64 secs1, const time64 secs2)
 {
+    PWARN ("gnc_difftime is deprecated");
     return (double)secs1 - (double)secs2;
 }
 

diff --git a/libgnucash/engine/gnc-date.h b/libgnucash/engine/gnc-date.h
@@ -224,6 +224,7 @@ gchar* gnc_ctime (const time64 *secs);
 time64 gnc_time (time64 *tbuf);
 
 /** \brief Find the difference in seconds between two time values
+ *         (deprecated)
  *  \param secs1: The first time value, in Seconds since
  * 00:00:00 UTC 01 January 1970 (negative values are seconds before that moment)
  *  \param secs2: The second time value, in Seconds since
-Original file line number
+Diff line change
@@ Expand Up / @@ -270,6 +270,7 @@ gnc_time (time64 *tbuf) @@
     gdouble
     gnc_difftime (const time64 secs1, const time64 secs2)
     {
+        PWARN ("gnc_difftime is deprecated");
         return (double)secs1 - (double)secs2;
     }
@@ Expand Down @@