Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance frontend performance: dynamic library imports & improved route-based code splitting #2259

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (cdb7893) to head (6dd14a0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2259   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         884      884           
  Lines       14683    14683           
=======================================
  Hits        14476    14476           
  Misses        207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cloudflare-workers-and-pages bot commented Mar 24, 2025

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6dd14a0
Status: ✅  Deploy successful!
Preview URL: https://7fcec055.gladys-plus.pages.dev
Branch Preview URL: https://dynamically-import-librairie.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented Mar 24, 2025

#3118 Bundle Size — 11.74MiB (+9.47%).

6dd14a0(current) vs cdb7893 master#3109(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 2 improvements
                 Current
#3118
     Baseline
#3109
Improvement  Initial JS 1.56MiB(-73.5%) 5.88MiB
Improvement  Initial CSS 261.41KiB(-14.35%) 305.21KiB
Change  Cache Invalidation 74.38% 54.74%
Change  Chunks 228(+347.06%) 51
Change  Assets 470(+171.68%) 173
Change  Modules 2057(+29.45%) 1589
Regression  Duplicate Modules 489(+2228.57%) 21
Change  Duplicate Code 10.81%(+1128.41%) 0.88%
No change  Packages 136 136
No change  Duplicate Packages 2 2
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
#3118
     Baseline
#3109
Regression  JS 8.72MiB (+12.69%) 7.74MiB
No change  IMG 2.54MiB 2.54MiB
Regression  CSS 326.36KiB (+1.02%) 323.06KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 48.9KiB (+167.22%) 18.3KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch dynamically-import-librairiesProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles changed the title Import librairies dynamically Enhance frontend performance: dynamic library imports & improved route-based code splitting Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant