-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Netatmo service to replace axios with undici for HTTP requests #2256
fix: Netatmo service to replace axios with undici for HTTP requests #2256
Conversation
Related to issue #2257 |
#3124 Bundle Size — 10.72MiB (0%).e982a74(current) vs cdb7893 master#3109(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #3124 |
Baseline #3109 |
|
---|---|---|
5.88MiB |
5.88MiB |
|
305.21KiB |
305.21KiB |
|
0% |
54.74% |
|
51 |
51 |
|
173 |
173 |
|
1589 |
1589 |
|
21 |
21 |
|
0.88% |
0.88% |
|
136 |
136 |
|
2 |
2 |
Bundle size by type no changes
Current #3124 |
Baseline #3109 |
|
---|---|---|
7.74MiB |
7.74MiB |
|
2.54MiB |
2.54MiB |
|
323.06KiB |
323.06KiB |
|
93.55KiB |
93.55KiB |
|
18.3KiB |
18.3KiB |
|
13.58KiB |
13.58KiB |
Bundle analysis report Branch Terdious:fix-Netatmo-patch-API-c... Project dashboard
Generated by RelativeCI Documentation Report issue
…ve error handling
…ck with undici for HTTP requests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2256 +/- ##
==========================================
- Coverage 98.59% 98.57% -0.02%
==========================================
Files 884 884
Lines 14683 14710 +27
==========================================
+ Hits 14476 14501 +25
- Misses 207 209 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast PR, a few feedbacks!
server/services/netatmo/lib/netatmo.loadWeatherStationDetails.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My Review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good to me :)
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Related to @William-De71's FR forum request Error / connection loss with NetAtmo Service