Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Netatmo service to replace axios with undici for HTTP requests #2256

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Mar 24, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Related to @William-De71's FR forum request Error / connection loss with NetAtmo Service

@Terdious Terdious self-assigned this Mar 24, 2025
@Terdious Terdious added the bug label Mar 24, 2025
@Terdious
Copy link
Contributor Author

Related to issue #2257

Copy link

relativeci bot commented Mar 24, 2025

#3124 Bundle Size — 10.72MiB (0%).

e982a74(current) vs cdb7893 master#3109(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#3124
     Baseline
#3109
No change  Initial JS 5.88MiB 5.88MiB
No change  Initial CSS 305.21KiB 305.21KiB
Change  Cache Invalidation 0% 54.74%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1589 1589
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.88% 0.88%
No change  Packages 136 136
No change  Duplicate Packages 2 2
Bundle size by type  no changes
                 Current
#3124
     Baseline
#3109
No change  JS 7.74MiB 7.74MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 323.06KiB 323.06KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 18.3KiB 18.3KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:fix-Netatmo-patch-API-c...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (cdb7893) to head (e982a74).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2256      +/-   ##
==========================================
- Coverage   98.59%   98.57%   -0.02%     
==========================================
  Files         884      884              
  Lines       14683    14710      +27     
==========================================
+ Hits        14476    14501      +25     
- Misses        207      209       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast PR, a few feedbacks!

@Terdious Terdious requested a review from Pierre-Gilles March 24, 2025 17:15
Copy link
Contributor Author

@Terdious Terdious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Review

@Terdious Terdious requested a review from Pierre-Gilles March 26, 2025 10:29
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me :)

@Pierre-Gilles Pierre-Gilles merged commit 660f2da into GladysAssistant:master Mar 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants