Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat scene actions button #2254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Mar 21, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Scene action buttons sticked at bottom

Improve scene action buttons UI by:

  • putting in a bottom sticky footer the Run / Save buttons
  • removeing dropdown and adding buttons for Duplicate / Delete buttons
  • adding a confirmation when user clicks on Delete

image

image

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (8bd0f3d) to head (cc1777b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2254   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         883      883           
  Lines       14664    14664           
=======================================
  Hits        14455    14455           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

relativeci bot commented Mar 21, 2025

#3102 Bundle Size — 10.72MiB (~-0.01%).

cc1777b(current) vs 8bd0f3d master#3097(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#3102
     Baseline
#3097
Improvement  Initial JS 5.88MiB(~-0.01%) 5.88MiB
No change  Initial CSS 305.21KiB 305.21KiB
Change  Cache Invalidation 57.69% 54.73%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1588 1588
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.89% 0.89%
No change  Packages 135 135
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#3102
     Baseline
#3097
Improvement  JS 7.74MiB (~-0.01%) 7.74MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 323.06KiB 323.06KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 18.3KiB 18.3KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch cicoub13:feat-scene-actions-butt...Project dashboard


Generated by RelativeCIDocumentationReport issue

@cicoub13 cicoub13 force-pushed the feat-scene-actions-button branch 2 times, most recently from d1641aa to dd8115d Compare March 22, 2025 06:53
@cicoub13 cicoub13 force-pushed the feat-scene-actions-button branch from dd8115d to cc1777b Compare March 22, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant