-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(2191): Migrate from ezsp to ember driver for Z2M #2196
base: master
Are you sure you want to change the base?
Conversation
#2933 Bundle Size — 10.41MiB (0%).084e89e(current) vs e9b3211 master#2931(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2933 |
Baseline #2931 |
|
---|---|---|
5.64MiB |
5.64MiB |
|
304.89KiB |
304.89KiB |
|
0% |
0% |
|
51 |
51 |
|
173 |
173 |
|
1511 |
1511 |
|
21 |
21 |
|
0.83% |
0.83% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type no changes
Current #2933 |
Baseline #2931 |
|
---|---|---|
7.43MiB |
7.43MiB |
|
2.54MiB |
2.54MiB |
|
321.79KiB |
321.79KiB |
|
93.55KiB |
93.55KiB |
|
17.79KiB |
17.79KiB |
|
13.58KiB |
13.58KiB |
Bundle analysis report Branch cicoub13:fix-2191 Project dashboard
Generated by RelativeCI Documentation Report issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2196 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 876 876
Lines 14420 14420
=======================================
Hits 14209 14209
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@cicoub13 Thanks for the PR! Were you able to test the PR? :) |
Not yet 😐 |
@cicoub13 If you need extra hardware to be able to test this without touching your main instance, don't hesitate 😄 (extra dongle, extra Linux server, anything) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Pierre-Gilles @cicoub13 . I'm running this update with the Sonoff E USB, and I find it very stable and fast with this new version of Zigbee2MQTT. I upgraded simultaneously to Zigbee2MQTT version 2.1.3. A great upgrade. I would recommend everyone to use the E version after this update. |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
From this part, no issue
Koenkk/zigbee2mqtt#21462 (comment)