Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rflink with tests #1204

Open
wants to merge 317 commits into
base: master
Choose a base branch
from
Open

Rflink with tests #1204

wants to merge 317 commits into from

Conversation

ngeissel
Copy link
Member

@ngeissel ngeissel commented May 26, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2024
@stale stale bot removed the stale label Oct 29, 2024
@Pierre-Gilles
Copy link
Contributor

@ngeissel Je vois que tu as cette PR ouverte depuis un bout de temps, et que tu la met à jour à chaque mise à jour de Gladys. J'imagine que c'est une image Docker que tu fais tourner chez toi et que tu gardes à jour ? :)

Est-ce que ça te dérangerait si je fermais cette PR côté Gladys ? Je pense que tu peux garder le repo de ton côté, et continuer de garder ton fork actif en re-mergant Gladys dedans à chaque mise à jour, mais sans forcément garder cette PR éternellement ici ^^

Dis moi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants