-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rflink with tests #1204
base: master
Are you sure you want to change the base?
Rflink with tests #1204
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@ngeissel Je vois que tu as cette PR ouverte depuis un bout de temps, et que tu la met à jour à chaque mise à jour de Gladys. J'imagine que c'est une image Docker que tu fais tourner chez toi et que tu gardes à jour ? :) Est-ce que ça te dérangerait si je fermais cette PR côté Gladys ? Je pense que tu peux garder le repo de ton côté, et continuer de garder ton fork actif en re-mergant Gladys dedans à chaque mise à jour, mais sans forcément garder cette PR éternellement ici ^^ Dis moi ! |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!