small typo #2268
Draft
small typo #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scazan
force-pushed
the
scottcazan/cache-docs-typo
branch
from
8f4dbd0
to
84e01f2
Compare
SamyPesse
reviewed
Apr 5, 2024
| @@ -126,6 +126,7 @@ export function cache<Args extends any[], Result>( | |||
| // Try the memory backend, independently of the other backends as it doesn't have a network cost | |||
| const memoryEntry = await memoryCache.get(key); | |||
| if (memoryEntry) { | |||
| console.log(`${key} memcache ${Date.now()} setAt=${memoryEntry.meta.setAt} expiresAt=${memoryEntry.meta.expiresAt} revalidatesAt=${memoryEntry.meta.revalidatesAt}`) | |||
There was a problem hiding this comment.
What is this log? do we need it? Cloudflare has some limits on logs
There was a problem hiding this comment.
Sorry, this was from debugging with Steven yesterday. We kinda messed this PR with logs in order to deploy logging to a Cloudflare deployment (since we can't see it locally). I'll create a new one for the typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.