Release: SSO, JSON field types, and File Upload Mutations #513
+1,660
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes similar fields to the evidence upload form. Due to Hasura issue number 2419, the file data must be passed in as a base64 string. The filename must also be provided separately. Tags are parsed by Taggit, as documented at [1]. tldr: a space or comma separated string, optionally with double quotes around tags. [1]: https://django-taggit.readthedocs.io/en/latest/forms.html
See notes of the previous commit for uploadEvidence for usage notes.
The extra field stores an arbitrary JSON subobject as a field on the root extra_fields object. This is intended for automated systems to fill out and provide data for templating. Since it's likely to contain a large value, Tte UI hides the value behind a button, like rich text fields. It also uses a plain non-rich-text textarea for editing.
With integrations attaching potentially large JSON blobs to the extra fields, they should not be loaded unless actually needed.
If someone uses the API endpoint to upload an image with a text file extension, the template tries to display the content as text and unicode throws an unhandled 500 error with `UnicodeDecodeError`. This change adds a check for a `UnicodeError`.
This was referenced Sep 10, 2024
`prepare_value`` seems to be passed an empty python `object` in some cases. Ignore when that happens and pass it through unchanged, which is consistent with other field implementations.
The handling still isn't great - the blockquote will generate its own paragraph "separate" from the list. But at least it won't throw an error anymore.
…ostManager/Ghostwriter into feature/sso-json-and-file-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This includes #489, #494, #501, and #502. Not much has changed from each individual PR, but this branch has been tested with all of them combined.
CHANGELOG
[4.3.0] – 3 Sep 2024
Added
Changed
django-allauthmodule used for authentication and SSOazureprovider is nowmicrosoftand SSO configurations will need to be updated