Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server switching with larger render distances #2168

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Camotoy
Copy link
Member

@Camotoy Camotoy commented Apr 23, 2021

The server only started sending its render distance during 1.14. ViaVersion compensates by sending 64 as the render distance, always - but this can choke up Bedrock in various ways. This PR fixes two separate issues related:

  • In some instances, the client would be stuck on Building Terrain during server switch. This is solved by fake-decreasing the render distance during server transfer. Zero issues have been found thus far.
  • When switching servers, chunks could be dropped. While not pretty, if the client is not spawned, they are teleported to near the chunks so they cannot be unloaded.

@jungwuk-ryu
Copy link
Contributor

May I ask when it will be merged?

@Camotoy
Copy link
Member Author

Camotoy commented May 16, 2021

I've been meaning to get some more testing going and possibly clean up the PR a bit - this feels hacky but hackiness is better than unworkable behavior.

@Camotoy Camotoy linked an issue May 22, 2021 that may be closed by this pull request
@hasankayra04
Copy link
Contributor

Is this pr going to be merged? Or is it solved by other means?

@PedroMPagani
Copy link

Is this still on the work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: client render distance value passed through to java server
5 participants