Skip to content

chore(deps): remove mml-react #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
526 changes: 141 additions & 385 deletions examples/capacitor/yarn.lock

Large diffs are not rendered by default.

1,823 changes: 841 additions & 982 deletions examples/nextjs/yarn.lock

Large diffs are not rendered by default.

448 changes: 89 additions & 359 deletions examples/typescript/yarn.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion examples/vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"eslint-plugin-react-refresh": "^0.4.6",
"sass": "^1.75.0",
"typescript": "^5.4.5",
"vite": "^5.2.10"
"vite": "^6.3.5"
}
}
942 changes: 347 additions & 595 deletions examples/vite/yarn.lock

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@
"use-sync-external-store": "^1.4.0"
},
"optionalDependencies": {
"@stream-io/transliterate": "^1.5.5",
"mml-react": "^0.4.7"
"@stream-io/transliterate": "^1.5.5"
},
"peerDependencies": {
"@breezystack/lamejs": "^1.2.7",
Expand Down
42 changes: 0 additions & 42 deletions src/components/MML/MML.tsx

This file was deleted.

135 changes: 0 additions & 135 deletions src/components/MML/__tests__/MML.test.js

This file was deleted.

1 change: 0 additions & 1 deletion src/components/MML/index.ts

This file was deleted.

7 changes: 1 addition & 6 deletions src/components/Message/FixedHeightMessage.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import React, { useCallback, useMemo } from 'react';

import { useActionHandler, useDeleteHandler, useUserRole } from './hooks';
import { useDeleteHandler, useUserRole } from './hooks';
import { MessageDeleted as DefaultMessageDeleted } from './MessageDeleted';
import { MessageTimestamp } from './MessageTimestamp';
import { getMessageActions } from './utils';

import { Avatar } from '../Avatar';
import { Gallery } from '../Gallery';
import { MessageActions } from '../MessageActions';
import { MML } from '../MML';

import { useChatContext } from '../../context/ChatContext';
import { useComponentContext } from '../../context/ComponentContext';
Expand Down Expand Up @@ -56,7 +55,6 @@ const UnMemoizedFixedHeightMessage = (props: FixedHeightMessageProps) => {
propGroupedByUser !== undefined ? propGroupedByUser : contextGroupedByUser;
const message = propMessage || contextMessage;

const handleAction = useActionHandler(message);
const handleDelete = useDeleteHandler(message);
const role = useUserRole(message);

Expand Down Expand Up @@ -106,9 +104,6 @@ const UnMemoizedFixedHeightMessage = (props: FixedHeightMessageProps) => {
{images && <Gallery images={images} />}
<div className='str-chat__virtual-message__text' data-testid='msg-text'>
{renderedText}
{message.mml && (
<MML actionHandler={handleAction} align='left' source={message.mml} />
)}
<div className='str-chat__virtual-message__data'>
<MessageActions
customWrapperClass='str-chat__virtual-message__actions'
Expand Down
8 changes: 0 additions & 8 deletions src/components/Message/MessageSimple.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import {
import { Avatar as DefaultAvatar } from '../Avatar';
import { Attachment as DefaultAttachment } from '../Attachment';
import { EditMessageModal } from '../MessageInput';
import { MML } from '../MML';
import { Poll } from '../Poll';
import { ReactionsList as DefaultReactionList } from '../Reactions';
import { MessageBounceModal } from '../MessageBounce/MessageBounceModal';
Expand Down Expand Up @@ -197,13 +196,6 @@ const MessageSimpleWithContext = (props: MessageSimpleWithContextProps) => {
) : (
<MessageText message={message} renderText={renderText} />
)}
{message.mml && (
<MML
actionHandler={handleAction}
align={isMyMessage() ? 'right' : 'left'}
source={message.mml}
/>
)}
<MessageErrorIcon />
</div>
</div>
Expand Down
12 changes: 0 additions & 12 deletions src/components/Message/__tests__/FixedHeightMessage.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { Avatar as AvatarMock } from '../../Avatar';
import { Gallery as GalleryMock } from '../../Gallery';
import { Message } from '../Message';
import { MessageActions as MessageActionsMock } from '../../MessageActions';
import { MML as MMLMock } from '../../MML';

import { ChannelActionProvider } from '../../../context/ChannelActionContext';
import { ChannelStateProvider } from '../../../context/ChannelStateContext';
Expand All @@ -24,7 +23,6 @@ import {
import { ComponentProvider } from '../../../context';

jest.mock('../../Avatar', () => ({ Avatar: jest.fn(() => <div />) }));
jest.mock('../../MML', () => ({ MML: jest.fn(() => <div />) }));
jest.mock('../../Gallery', () => ({ Gallery: jest.fn(() => <div />) }));
jest.mock('../../MessageActions', () => ({
MessageActions: jest.fn((props) => props.getMessageActions()),
Expand Down Expand Up @@ -95,16 +93,6 @@ describe('<FixedHeightMessage />', () => {
);
});

it('should render MML', async () => {
const mml = '<mml>text</mml>';
const message = generateMessage({ mml, user: alice });
await renderMsg(message);
expect(MMLMock).toHaveBeenCalledWith(
expect.objectContaining({ align: 'left', source: mml }),
undefined,
);
});

it('should render message action for owner', async () => {
const message = generateMessage({ user: alice });
await renderMsg(message);
Expand Down
29 changes: 0 additions & 29 deletions src/components/Message/__tests__/MessageSimple.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { Chat } from '../../Chat';
import { Attachment as AttachmentMock } from '../../Attachment';
import { Avatar as AvatarMock } from '../../Avatar';
import { getReadStates } from '../../MessageList';
import { MML as MMLMock } from '../../MML';
import { defaultReactionOptions } from '../../Reactions';

import {
Expand Down Expand Up @@ -48,7 +47,6 @@ jest.mock('../MessageOptions', () => ({
jest.mock('../MessageText', () => ({
MessageText: jest.fn(() => <div data-testid='mocked-message-text' />),
}));
jest.mock('../../MML', () => ({ MML: jest.fn(() => <div data-testid='mocked-mml' />) }));
jest.mock('../../Avatar', () => ({
Avatar: jest.fn(() => <div data-testid='mocked-avatar' />),
}));
Expand Down Expand Up @@ -563,33 +561,6 @@ describe('<MessageSimple />', () => {
expect(results).toHaveNoViolations();
});

it('should render MML', async () => {
const mml = '<mml>text</mml>';
const message = generateAliceMessage({ mml });
const { container } = await renderMessageSimple({ message });
expect(MMLMock).toHaveBeenCalledWith(
expect.objectContaining({ align: 'right', source: mml }),
undefined,
);
const results = await axe(container);
expect(results).toHaveNoViolations();
});

it('should render MML on left for others', async () => {
const mml = '<mml>text</mml>';
const message = generateBobMessage({ mml });
const { container } = await renderMessageSimple({
message,
props: { isMyMessage: () => false },
});
expect(MMLMock).toHaveBeenCalledWith(
expect.objectContaining({ align: 'left', source: mml }),
undefined,
);
const results = await axe(container);
expect(results).toHaveNoViolations();
});

it('should render message text when message has text', async () => {
const message = generateAliceMessage({ text: 'Hello' });
const actionsEnabled = true;
Expand Down
1 change: 0 additions & 1 deletion src/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export * from './MessageActions';
export type { MessageBouncePromptProps } from './MessageBounce';
export * from './MessageInput';
export * from './MessageList';
export * from './MML';
export * from './Modal';
export * from './Notifications';
export * from './Poll';
Expand Down
Loading