refactor: adjust THREAD_RESPONSE_RESERVED_KEYS to be a dictionary instead #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
MartinCupela and
myandrienko
as code owners
myandrienko
approved these changes
Jan 17, 2025
arnautov-anton
force-pushed
the
refactor/thread-response-reserved-keys
branch
from
b72e21d to
ab96dab
Compare
|
Size Change: +5 B (0%) Total Size: 465 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
Rename
THREAD_RESERVED_KEYStoTHREAD_RESPONSE_RESERVED_KEYS, change it into a dictionary for better type safety, testcustomobject to not include reserved keys as well.